Preserve/inherit indentation levels. #237
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is purely aesthetic, but I think it's pretty important (especially at DIY where we hope to have kids reading the page source). Currently with handlebars, using partials causes indentation levels of the output to get borked. Here's the scenario:
"head" partial:
Current Output:
Fixed Output:
With this update, the output looks like this:
The update reads the indentation level of the last line of the
content
block preceding the partial, and transfers it to every line of the partial output (except the first). Works with spaces, tabs, or a mixture of the two.Note: I made sure that the modifications to
runtime.js
will not break existing precompiled templates.(p.s. Sorry for submitting this twice... I forgot about another change I wanted to submit as a separate pull request, so I had to set up some branches.)