Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetris_game 7-bag randomizer not being reset after a game over #37

Open
Alloy-Lou opened this issue Jan 3, 2024 · 4 comments
Open

tetris_game 7-bag randomizer not being reset after a game over #37

Alloy-Lou opened this issue Jan 3, 2024 · 4 comments

Comments

@Alloy-Lou
Copy link

The 7 bag randomizer is not being reset after a game over or when starting a new game

How to reproduce :

  • Drop exactly 5 piece
  • Press back button ("The game is now paused")
  • Press menu button (Start a new game)
  • Notice the first dropping piece doesn't follow the 7-bag rule, with a bit of luck you'll notice the falling piece and the next piece being the exact same.

Also works after a game over.
Not sure that when pressing the menu button while the game is paused, starting a new game is an intended behavior.

I also have a few suggestions to improve the game (such as implementing counter-clockwise rotation with up button, or add hold feature, improve piece preview with more previews, add lock delay, improve scoring system with b2bs... -> being closer to the official Tetris Guideline), I'd happily contribute.

@noiob
Copy link
Contributor

noiob commented Feb 6, 2024

the center button isn't supposed to start a new game when paused, that's a bug

not resetting after a game over is a bug too

@Alloy-Lou
Copy link
Author

I fixed these bugs and I'm currently working on additional features, feel free to dm me on Discord (@alloy_lou), maybe we could work together?

@noiob
Copy link
Contributor

noiob commented Feb 10, 2024

sorry, I pretty much just fixed some stuff that annoyed me in the game so it'd be more fun for me. I'm not really a C dev :D

@Alloy-Lou
Copy link
Author

oh i see, i recently started C too. Would you at least be interested in testing the game so I could have feedback, or find bugs i wouldn't have seen alone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants