[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep'

[rolfbjarne]

Removing (and storing) the attributes earlier make it's possible for them not
to be marked. IOW the attribute type itself (and not just the decorations) can
be removed.

One side effect is that we'll have to manually mark the protocol wrapper type
referenced in the [Protocol] attribute, since the [Protocol] attribute is now
removed.

Inspired by / extracted from #14270.

[vs-mobiletools-engineering-service2]

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]

[stephen-hawley]

👍

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 24 tests failed, 76 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

• DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

• DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

• DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

• DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ linker tests

4 tests failed, 36 tests passed.

• link sdk/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
• link all/Mac [dotnet]/Release [dotnet]: BuildFailure
• link all/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
• trimmode link/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

2 tests failed, 5 tests passed.

• monotouch-test/iOS Unified 64-bits - simulator/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure
• monotouch-test/iOS Unified 64-bits - simulator/Release (NativeAOT, x64) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

8 tests failed, 2 tests passed.

• monotouch-test/Mac Catalyst [dotnet]/Release (ARM64, LLVM) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Release (static registrar) [dotnet]: Failed (Test run failed.
  Tests run: 3051 Passed: 2882 Inconclusive: 10 Failed: 1 Ignored: 168)
• monotouch-test/Mac Catalyst [dotnet]/Release (managed static registrar) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT, ARM64) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
• monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT, x64) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Release (static registrar, all optimizations) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

6 tests failed, 7 tests passed.

• monotouch-test/Mac [dotnet]/Release (NativeAOT, ARM64) [dotnet]: BuildFailure
• monotouch-test/Mac [dotnet]/Release (NativeAOT, x64) [dotnet]: BuildFailure
• monotouch-test/Mac [dotnet]/Release (NativeAOT) [dotnet]: BuildFailure
• monotouch-test/Mac [dotnet]/Release (static registrar, all optimizations) [dotnet]: Failed (Test run failed.
  Tests run: 3009 Passed: 2794 Inconclusive: 4 Failed: 1 Ignored: 214)
• monotouch-test/Mac [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure
• monotouch-test/Mac Catalyst [dotnet]/Debug (ARM64) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3be5cf885ee515fa51830e38ef68e5a79c1cffcb [PR build]