Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Preserve a required method in System.Private.CoreLib to work around a bug in .NET 6. #10426

Merged

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Jan 14, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

6 tests failed, 35 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: Failed (Test run crashed)
  • xammac tests/Mac Modern/Debug (all optimizations): Failed (Test run crashed)
  • xammac tests/Mac Modern/Release: Failed (Test run crashed)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Test run crashed)
  • [NUnit] Mono Mac OS X BCL tests group 3/Mac Modern/Debug: Failed (Tests run: 8755 Passed: 8174 Inconclusive: 0 Failed: 1 Ignored: 46)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1106

@rolfbjarne

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@rolfbjarne
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 40 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1095'

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https:/xamarin/maccore/issues/2154)

@rolfbjarne rolfbjarne merged commit 29727d6 into xamarin:main Jan 15, 2021
spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Jun 17, 2021
…to work around a bug in .NET 6. (xamarin#10426)"

This reverts commit 29727d6.

dotnet/runtime#46908 was fixed and the other part of the workaround was removed in PR#11958
spouliot added a commit that referenced this pull request Jun 18, 2021
…to work around a bug in .NET 6. (#10426)" (#11974)

This reverts commit 29727d6.

dotnet/runtime#46908 was fixed and the other part of the workaround was removed in PR#11958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants