[tools] Revert workaround for dotnet/runtime#45535. #12011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dotnet/runtime issue in question has been fixed. Ref: dotnet/runtime#45535 Ref: xamarin@39948aa
rolfbjarne
added
not-notes-worthy
|
CC @filipnavara |
|
LGTM. The workaround for |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results31 tests failed, 84 tests passed.Failed tests
|
|
@filipnavara looks like it's not fully fixed in dotnet/runtime: |
|
That's really weird. I will need to verify that the consumed assets are the correct ones. The blocking P6/P7 bumps are not making that easy. |
|
@filipnavara here are build logs if that helps: |
|
It is still broken for System.Net.Http and System.Net.Mail on the dotnet/runtime side. The same fix that was applied here: System.Net.Security does appear to be fixed though. cc @MaximLipnin |
mandel-macaque
approved these changes
Jul 16, 2021
spouliot
approved these changes
Jul 20, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results11 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
|
@filipnavara / @MaximLipnin: as of is this known? |
Not to me. The PR in dotnet/runtime was supposed to fix this. I'll check what is going on and how System.Net.Mail.dll is packed in the runtime packs. (Side-note: I'm going to be out of civilisation for the next couple of days so if someone gets to it earlier than Monday then feel free to attack it.) |
|
Apparently these files: |
akoeplinger
pushed a commit
to dotnet/runtime
that referenced
this pull request
Jul 26, 2021
61 tasks
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 117 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https:/xamarin/maccore/issues/2443). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet/runtime issue in question has been fixed.
Ref: dotnet/runtime#45535
Ref: 39948aa