[runtime] Implement computing and passing the NATIVE_DLL_SEARCH_DIRECTORIES runtime property. Fixes #10504. #12309
Conversation
…TORIES runtime property. Fixes xamarin#10504. This adds support to compute the NATIVE_DLL_SEARCH_DIRECTORIES value and pass it to the runtime. It's the last property listed in xamarin#10504, so this fixes that issue. Fixes xamarin#10504
rolfbjarne
added
not-notes-worthy
|
|
||
| // Join them all together with a colon separating them | ||
| NSString *joined = [directories componentsJoinedByString: @":"]; | ||
| char *rv = xamarin_strdup_printf ("%s", [joined UTF8String]); |
There was a problem hiding this comment.
There was a problem hiding this comment.
The return value from that function is only valid for as long as the NSString is alive: "The returned C string is guaranteed to be valid only until either the receiver is freed". I could use getCString:maxLength:encoding: instead, but that ends up making the code somewhat longer and more complex, and this is a one-time thing at startup, so I don't think it matters all that much.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 115 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https:/xamarin/maccore/issues/2443). |
This adds support to compute the NATIVE_DLL_SEARCH_DIRECTORIES value and pass
it to the runtime. It's the last property listed in #10504, so this fixes that
issue.
Fixes #10504