Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datacontainer): parameter list serialization #193

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

nicrie
Copy link
Contributor

@nicrie nicrie commented Aug 25, 2024

This PR includes a refactoring of the DataContainer module to allow for the serialization of parameter lists. The changes ensure that boolean and None values are converted to strings when validating attributes, even when they are present within a list.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@db03601). Learn more about missing BASE report.

Files Patch % Lines
xeofs/data_container/data_container.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #193   +/-   ##
==========================================
  Coverage           ?   25.16%           
==========================================
  Files              ?       45           
  Lines              ?     3430           
  Branches           ?        0           
==========================================
  Hits               ?      863           
  Misses             ?     2567           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicrie nicrie merged commit 7b9764d into develop Aug 25, 2024
8 checks passed
@nicrie nicrie deleted the serialize-parameter-list branch August 25, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant