fix some linking errors caused by collisions with openssl #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleroy
added a commit
that referenced
this pull request
Apr 16, 2024
As reported in #35, some of the C files in this library (e.g. src/poly1305-donna.c) are also present in other libraries, causing name collisions for the functions they export. This commit applies a `static` modifier to all C functions exported by these files, and includes directly the C files in the stub-*.c files. In the end, the only functions exported are now the OCaml/C stub functions, prefixed by `caml_`. The `static` modifier is hidden behind a `EXPORT` macro, so that the original visibility can be restored by compiling with `-DEXPORT=`, if that's ever needed.
xavierleroy
added a commit
that referenced
this pull request
Apr 16, 2024
As reported in #35, some of the C files in this library (e.g. src/poly1305-donna.c) are also present in other libraries, causing name collisions for the functions they export. This commit applies a `static` modifier to all C functions exported by these files, and includes directly the C files in the stub-*.c files. In the end, the only functions exported are now the OCaml/C stub functions, prefixed by `caml_`. The `static` modifier is hidden behind a `EXPORT` macro, so that the original visibility can be restored by compiling with `-DEXPORT=`, if that's ever needed. While we're at it: removed the remaining `$Id` comments.
|
Thanks for reporting this naming problem. Given that crypto code is often reused as is (with the same function names) between several projects, it could make sense to address the issue more generally. Prefixing all non-static identifiers with |
xavierleroy
added a commit
that referenced
this pull request
Jun 7, 2024
As reported in #35, some of the C files in this library (e.g. src/poly1305-donna.c) are also present in other libraries, causing name collisions for the functions they export. This commit applies a `static` modifier to all C functions exported by these files, and includes directly the C files in the stub-*.c files. In the end, the only functions exported are now the OCaml/C stub functions, prefixed by `caml_`. The `static` modifier is hidden behind a `EXPORT` macro, so that the original visibility can be restored by compiling with `-DEXPORT=`, if that's ever needed. While we're at it: removed the remaining `$Id` comments.
|
Let's go with #36 ! Thanks for your feedback. |
|
Thank you!! :)
…On June 7, 2024 4:58:56 AM EDT, Xavier Leroy ***@***.***> wrote:
Let's go with #36 ! Thanks for your feedback.
--
Reply to this email directly or view it on GitHub:
#35 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on alpine, trying to do a static build with cryptokit and openssl (pulled in by another library), I met some symbol collisions that could only be fixed by prefixing C functions. For uniformity I renamed all the public C functions for sha3 and poly1305-donna so they start with
cryptokit_.