This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Summary
SumMessage {RoundBox, SumBox}
using asealedbox
and abox_
, each with their respective buffers. this is now simplified to aSumMessage
using only asealedbox
(same for update and sum2). the only minor drawback is that each message must now contain its receiver (the coordinator pk) to avoid surreptitious forwarding (but that information is available anyway and only contributes to an additional 32 bytes, which is way less than the previous construction).then_some
andthen
from the unstablebool_to_option
featurecertificate
,masked_model
,local_dict_seed
andmask
fieldsFrom
/Into
andTryFrom
/TryInto
traits instead of customfrom
implementationsNotes
mask
instead ofmask_hash
: we are submitting whole masks directly via the messages for the first implementation, uploading to buckets might come later. the coordinator still stores only hashed masks in themask_dict
for efficiency.masked_model
instead ofmodel_url