-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport][widevine] add support for linux arm64 #1130
Conversation
without these changes, the following error is observed: Initialize: Failed to load library: libwidevinecdm.so: undefined symbol: __aarch64_ldadd4_acq_rel Unable to load widevine shared library (libwidevinecdm.so)
you can avoid ping peak3d it on threads is not on kodi team from many years i think you have better knowledge of what is involved in loading the library where linux its not my area but i am a bit concerned about asm implementation for dynamic symbols i think its better ping also @phunkyfish |
I updated the code to remove the ASM. Technically the ASM version will have increased performance because it can use the LSE extensions, but I don't think that's a big deal here. I left that implementation in the git history for reference in case it becomes an issue in the future. |
There is an additional problem to be taken in account |
Options would be:
|
@tmm1 can you create same PR for Omega branch? |
So for arm64 Kodi devices, they will need minimum whatever version IA that is released after this is merged? If so, I'll add a IA version check in my addons to give error if IA version too old for 64bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tmm1 for finding the arm64 libraries and kicking this off
where is my thanks 😆 , I am the one who noticed the widevine commit in chromium last fall, and that all the arm64 chromeOS CI was in place in January and asked in the google groups. But we really have Doug Anderson to thank. |
I guess I was trying to thank tmm1 for bringing it into the space here. Thanks to you for the digging in the first place. In the future though if there's new CDM platform/archs that become available and you find them please share the info with us so we know about it, we would be very grateful. |
so how i get widevine support to work on arm64? the inputstream adaptive helper still claims arm64 is not supported. |
@Schlumpf7 Have a read through this: emilsvennesson/script.module.inputstreamhelper#530 |
Hello, there seems to be a gcc fix from fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1830472 |
without these changes, the following error is observed:
cc #1128 emilsvennesson/script.module.inputstreamhelper#530
cc @matthuisman @glennguy @peak3d @knaerzche @jernejsk
for reference: