[script.module.youtube.dl@matrix] 23.04.01+matrix.1

[joaopa00]

Description

Update to the Git version of 01/04/2023 of youtube-dl

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

[joaopa00]

Is it possible to have a feedback for this PR?

Thanks in advance.

[joaopa00]

Any feedback would be welcome. Thanks in advance

[romanvm]

Sorry for a very late reply. I finally have some spare time to clean our backlog. I'd like to know where the code was taken from. The PR is very big and reviewing it will take some time. However, if the code has some authoritative source, like popular Python libraries, I can just compare file hashes that will speed-up the process significantly.

[joaopa00]

Yes, this plugin is just a wrapper for Kodi for the very-well known software youtube-dl youtubedl

This plugin wraps all the extractors of youtube-dl in a plugin usable by Kodi. Obviuously all the extractors can fetch legally available video links only. Video link needing paying subscriptions can not be downloaded by youtube-dl (oyr you have to pay the video website to know what the link is).

Thanks for the review. Youtube changed its api very lon ago. Catchuptvandmore can not read youtube link now. So many video can not be played by catchuptvandmore now, So Catchuptvandmore is stuck at beta version since a very long time until it is usable again for youtube videos.

A note: if you have administrator rights for xbmc/repo-resources, can you merge images for CUTVM ?

[romanvm]

@joaopa00 Images addon is merged.

Regarding this addon, could you point me to the exact tag or commit in the upstream repo that this PR is based on? Because the latest tag there is 2021.12.17 and the PR description above says "01/04/2023". Personally, I don't expect anything fishy in this PR but I want to do due diligence and at least compare MD5s.

[joaopa00]

This PR is based on GIT dated of April 1 2023.
From what I understood Youtube-dl did not release new stable version because of some problems with cross-compiling on some platforms . There is no such problem for Kodi since we use only extractor that are python written.
no new release for Youtube-dl

[romanvm]

LGTM

[romanvm]

@joaopa00 Next time please note the commit in the youtube-dl repo that your PR is based on. It will speed up the process significantly. Thanks in advance.