Skip to content

Commit

Permalink
[FOLD] Improve remote setup step
Browse files Browse the repository at this point in the history
* Stolen from (4716 discussion)
* Also add note to test step that it can fail
  • Loading branch information
ximinez committed Oct 2, 2023
1 parent e308801 commit 8f1c1e4
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ jobs:
shell: bash
id: remote
run: |
set +e
conan user --remote ripple ${{ secrets.CONAN_USERNAME }} --password ${{ secrets.CONAN_TOKEN }}
echo outcome=$([ $? -eq 0 ] && echo success || echo failure) | tee ${GITHUB_OUTPUT}
echo outcome=$(conan user --remote ripple ${{ secrets.CONAN_USERNAME }} \
--password ${{ secrets.CONAN_TOKEN }} >&2 && echo success || \
echo failure) | tee ${GITHUB_OUTPUT}
- name: list missing binaries
id: binaries
shell: bash
Expand All @@ -91,12 +91,11 @@ jobs:
configuration: ${{ matrix.configuration }}
# Hard code for now. Move to the matrix if varied options are needed
cmake-args: '-Dassert=ON -Dreporting=OFF -Dunity=OFF'
- name: test
- name: test (permitted to silently fail)
shell: bash
# Github runners are resource limited, which causes unit tests to fail
# (e.g. OOM). To allow forward progress until self-hosted runners are
# up and running reliably, allow the job to succeed even if tests fail.
continue-on-error: true
run: |
# Remove these echo statements before merging
${build_dir}/${{ matrix.configuration }}/rippled --unittest --unittest-jobs $(nproc)

0 comments on commit 8f1c1e4

Please sign in to comment.