-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please stop changing the state keys #128
Comments
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As you can see here: https:/rlaphoenix/VSGAN/blob/a81c177f00ee8cfb5bbc847c0da0ce2b5ad9d4ec/vsgan/archs/ESRGAN.py#L42
I need to manually do some key name replacing and regex checks to be able to support all models of all 3 types of RRDBNet archs you have done for: Original ESRGAN, Later ESRGAN (Near BasicSR), as well as Real-ESRGAN.
Please try not to change the state keys so much as it breaks compatibility with old models for testing and gives other devs a headache to try support them all. Thanks.
The text was updated successfully, but these errors were encountered: