-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library prefix in MSVC files. #14
Comments
The CMake build files are quite new, so I would guess most projects use the libogg name. In addition, on Linux, it's also libogg. I think changing CMakelists.txt in both Ogg and Vorbis is probably sensible. Other users of Ogg (Opus and Theora) have no cmake support at all. |
@adrianbrohe Cannot reproduce issue. Tested and confirmed resolved. |
Same here. That makes it impossible to link the correct dll without renaming it. |
Hello,
currently the MSVC project files define a
lib
prefix for the ogg library, leading to alibogg.dll
shared library, alibogg.lib
import library and alibogg_static.lib
static library. This is inconsistent with the output generated by CMake, which in the current configuration creates aogg.dll
shared library, aogg.lib
import library and aogg.lib
static library.But how to fix this? It's possible to change the MSVC projects or to set the prefix in the CMake configuration. The lib prefix isn't removed by the linker during runtime linking so one would always need to link against
libogg
on windows, making it inconsistent across platforms where you link againstogg
, making cross platform builds a bit harder (eg. you would need to update the CMakelists.txt of the vorbis project to search for libogg too instead of just searching for ogg). On the other hand it would break compatibility in the sense that clients who use libogg in their project file, causing link error until the linker dependency is changed from libogg.lib to ogg.lib.The text was updated successfully, but these errors were encountered: