Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating PartnerIDs #79

Merged
merged 12 commits into from
Sep 21, 2021
Merged

Integrating PartnerIDs #79

merged 12 commits into from
Sep 21, 2021

Conversation

mtrinh11
Copy link
Contributor

No description provided.

transport.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

service.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport_test.go Show resolved Hide resolved
@mtrinh11 mtrinh11 requested a review from joe94 September 17, 2021 18:14
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #79 (1f11c14) into main (2e60b22) will increase coverage by 1.04%.
The diff coverage is 87.50%.

❗ Current head 1f11c14 differs from pull request most recent head 6f7a522. Consider uploading reports for the commit 6f7a522 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   81.01%   82.06%   +1.04%     
==========================================
  Files          10       10              
  Lines         432      474      +42     
==========================================
+ Hits          350      389      +39     
- Misses         73       75       +2     
- Partials        9       10       +1     
Impacted Files Coverage Δ
jwtAcquireParser.go 80.00% <ø> (ø)
service.go 44.89% <70.00%> (+2.50%) ⬆️
endpoint.go 100.00% <100.00%> (ø)
transport.go 96.36% <100.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e60b22...6f7a522. Read the comment docs.

service.go Show resolved Hide resolved
service.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
transport_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

transport.go Outdated Show resolved Hide resolved
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtrinh11 mtrinh11 merged commit a46d058 into xmidt-org:main Sep 21, 2021
@mtrinh11 mtrinh11 deleted the partnerIDs branch September 21, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants