-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure gauge for outbound queue is 0 on startup #203
Labels
Comments
Setting the gauge to 0 for each label was done in this pr: Fixing the metrics to create counters and metrics once instead of in a variety of different structs can be done at a later time. This will probably be partially or completely done as a part of moving to uber.fx or creating a separate library for the outbound sender. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
caduceus/metrics.go
Line 150 in 00ce0db
Instead of making new gauges and other metrics for each outbound sender, we should create these once for caduceus and then pass what is needed to the outbound senders.
Then, we can easily set the gauge to 0 on startup, which hopefully will fix the issue of the gauge getting stuck on a specific queue depth that doesn't look correct:
Edit: this is unlikely to fix the gauge issue, but would still be a nice fix to make.
The text was updated successfully, but these errors were encountered: