-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve senderWrapper Update func #226
Labels
Comments
kristinapathak
added
enhancement
argus-webhooks
Securing webhooks for the switch to argus
labels
Jul 16, 2020
kristinapathak
changed the title
We should update better
Improve senderWrapper Update func
Jul 16, 2020
When discussing a production issue in Caduceus, I remember @schmidtw saying that he wants to maintain Caduceus' functionality of holding onto an expired webhook for a bit. So I'm not sure if we should do this or how we could do this to maintain that functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
caduceus/senderWrapper.go
Line 132 in 453f141
With argus, we don't need the undertaker anymore and should delete webhooks in our update function.
The text was updated successfully, but these errors were encountered: