added validation for transaction uuid #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
changed the title
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 47.69% 47.79% +0.09%
==========================================
Files 24 24
Lines 4344 4352 +8
==========================================
+ Hits 2072 2080 +8
Misses 2087 2087
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnabass
requested changes
Aug 28, 2023
wrphttp/handler.go
Outdated
| @@ -128,6 +129,15 @@ func (wh *wrpHandler) ServeHTTP(httpResponse http.ResponseWriter, httpRequest *h | |||
| return | |||
| } | |||
|
|
|||
| if entity.Message.Type == 3 && entity.Message.TransactionUUID == "" { | |||
There was a problem hiding this comment.
Aren't there additional message types that require a TransactionUUID? I thought all the CRUD ones do as well.
In any case, I would use the MessageType.SupportsTransaction method to determine if it has a message type:
if entity.Message.Type.SupportsTransaction() && len(entity.Message.TransactionUUID) == 0 {
// etc
}
Given that we're requiring a transaction UUID now, that method should probably change to something clearer, like RequiresTransactionUUID.
EDIT:
For reference: https:/xmidt-org/wrp-go/blob/main/messagetype.go#L50
johnabass
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https:/comcast-cl/xmidt/issues/571