Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validator metrics #152

Merged
merged 11 commits into from
Jan 19, 2024
Merged

Conversation

denopink
Copy link
Contributor

No description provided.

@denopink denopink self-assigned this Jan 18, 2024
Copy link

guardrails bot commented Jan 18, 2024

⚠️ We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
High pkg:golang/github.com/xmidt-org/[email protected] upgrade to: > v0.1.5
High pkg:golang/github.com/prometheus/[email protected] upgrade to: > v1.18.0

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (f8fe56b) 47.65% compared to head (4f01f5d) 49.75%.
Report is 3 commits behind head on main.

❗ Current head 4f01f5d differs from pull request most recent head e0879de. Consider uploading reports for the commit e0879de to get more accurate results

Files Patch % Lines
messages_codec.go 34.21% 36 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   47.65%   49.75%   +2.10%     
==========================================
  Files          24       25       +1     
  Lines        4342     4524     +182     
==========================================
+ Hits         2069     2251     +182     
  Misses       2083     2083              
  Partials      190      190              
Flag Coverage Δ
unittests 49.75% <82.81%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink merged commit 4f92637 into main Jan 19, 2024
13 of 14 checks passed
@denopink denopink deleted the denopink/feat/validator-metrics-config branch January 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant