Add properties to Mojo parameters checkStaleness and staleMillis #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue while at work where it would be really valuable to have these properties accessible via maven's `-D` flag
I used version 0.6.1 since it was the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
propertydefinitions to theAbstractProtocMojofieldscheckStalenessandstaleMillisfor use from the maven CLI (mvn). The need for this change came about while trying to improve the maven build times for the backend at my work, and I noticed I couldn't change thecheckStalenessconfiguration property, as I might in other maven plugins (ex:mvn package -DskipTests -Djacoco.skip=true). I hope this adds some additional value to an already fantastic project.I'm relatively unfamiliar with how Mojo/Maven plugins work, so if I've made a mistake please let me know and I will correct it.
Additinally, I wasn't sure what version to use when adding
@since <version>to the doc comments for the parameters I updated, so I used the latest version.