Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media extensions — add support for Yandex.Music & VK #187

Closed
leotsarev opened this issue Dec 28, 2017 · 1 comment · Fixed by #193
Closed

Media extensions — add support for Yandex.Music & VK #187

leotsarev opened this issue Dec 28, 2017 · 1 comment · Fixed by #193

Comments

@leotsarev
Copy link
Contributor

Hi, I'm seeking to add embedding audio from VKontakte & Yandex.Music (pretty popular in Russia) and video from VKontakte.
I'm going to implement it myself, just checking with you if PRs are welcome.

@xoofx
Copy link
Owner

xoofx commented Dec 30, 2017

Yes. this should be part of the existing MediaLinks extension. Currently, the code is hardcoded, but if we could setup things through options instead, that would be fine (e.g a list of regex or similar), not sure if it is generalize-able, but you can check with your usecase and we will see what to do from there:

https:/lunet-io/markdig/blob/0bb8139450794ee55491011c7110575fbc683efb/src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs#L63-L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants