Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolink does not recognize domain names followed by URL fragments query or port #258

Closed
yufeih opened this issue Oct 25, 2018 · 3 comments
Closed

Autolink does not recognize domain names followed by URL fragments query or port #258

yufeih opened this issue Oct 25, 2018 · 3 comments

Comments

@yufeih
Copy link
Contributor

yufeih commented Oct 25, 2018

Due to #253, https:#a, https:?a, https::443 is no longer recognized as autolink. The spec does not say about requiring a / after domain name, browsers can also handles these types of links just fine.

cc @MihaZupan
@yufeih yufeih changed the title Autolink does not recognize domain names followed by URL fragments Autolink does not recognize domain names followed by URL fragments query or port Oct 25, 2018
@MihaZupan
Copy link
Collaborator

I see, I think the only change needed here is to check for these characters along with the '/' check in LinkHelper. I'll do a PR when I get to a computer.

@MihaZupan MihaZupan mentioned this issue Oct 25, 2018
Merged
@xoofx
Copy link
Owner

xoofx commented Oct 29, 2018

Fixed by PR #260

@xoofx xoofx closed this as completed Oct 29, 2018
@yufeih
Copy link
Contributor Author

yufeih commented Oct 30, 2018

Thank you guys for the fix, awesome 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yufeih @xoofx @MihaZupan