Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dropwizard 5.0 #376

Open
lifey opened this issue Feb 5, 2024 · 5 comments
Open

Support Dropwizard 5.0 #376

lifey opened this issue Feb 5, 2024 · 5 comments

Comments

@lifey
Copy link

lifey commented Feb 5, 2024

Dropwizard 5.0 (bundling Jetty12) is in alpha release. https://central.sonatype.com/artifact/io.dropwizard/dropwizard-core/overview
Currently dropwizard-guicey does not support it and fails to start
java.lang.NoSuchMethodError: 'void io.dropwizard.jetty.MutableServletContextHandler.setAttribute(java.lang.String, java.lang.Object)'
at ru.vyarus.dropwizard.guice.module.context.SharedConfigurationState.listen(SharedConfigurationState.java:258)
at ru.vyarus.dropwizard.guice.module.context.ConfigurationContext.runPhaseStarted(ConfigurationContext.java:710)
at ru.vyarus.dropwizard.guice.module.GuiceyRunner.(GuiceyRunner.java:43)
at ru.vyarus.dropwizard.guice.GuiceBundle.run(GuiceBundle.java:133)
at ru.vyarus.dropwizard.guice.GuiceBundle.run(GuiceBundle.java:101)
at io.dropwizard.core.setup.Bootstrap.run(Bootstrap.java:199)

I have tried to compile it and there are several compilation issues relate to jakarta-ee decoupling from jetty

@xvik
Copy link
Owner

xvik commented Feb 6, 2024

Thank you! I'll look.

@lifey
Copy link
Author

lifey commented Feb 6, 2024

Thanks @xvik if you need help with this LMK :)

@xvik
Copy link
Owner

xvik commented Feb 6, 2024

Checked: everything is good. Just a few packages renamed (for example, org.eclipse.jetty.servlet.FilterHolder become org.eclipse.jetty.ee10.servlet.FilterHolder).

Plus, ServerPushFilterFactory was removed with related configuration (it was already deprecated).

There is a problem with admin-rest extension in case of async resources, but I doubt anyone use async admin rest at all.
Will look closer later.

I did not push the changes (just shelved) because I don't want to maintain another branch right now.
Will push it into master when at least beta would be released.

@lifey
Copy link
Author

lifey commented Feb 6, 2024

Thanks @xvik for the rapid response

@xvik
Copy link
Owner

xvik commented Sep 17, 2024

Dropwizard 5 support (alpha 2) pushed into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants