Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of svg on some attributes #130

Closed
arturasn opened this issue Feb 12, 2020 · 3 comments
Closed

Incorrect rendering of svg on some attributes #130

arturasn opened this issue Feb 12, 2020 · 3 comments
Labels
bug help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request.

Comments

@arturasn
Copy link

Some elements of the SVG are rendered incorrectly compared the html and pdf generated version of the svg2pdf.js
I have made a jsFiddle to reproduce the errors: link
I expect the SVG in the pdf look the same as in html, however currently this is not the case.
Issues from what I see(maybe exists more):

  1. Gradient is not used (I have played with this a little bit and not ommiting default values(x1="0%" y1="0%" x2="100%" y2="0%") seem to fix this however it should work regardless.
  2. Vertical text incorrect positioning
  3. Text and line in the center lifted up higher than expected
@HackbrettXXX
Copy link
Member

Thank you for the bug report.

@HackbrettXXX HackbrettXXX added bug help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request. labels Feb 12, 2020
@arturasn
Copy link
Author

arturasn commented Nov 5, 2020

  1. Vertical text incorrect positioning
  2. Text and line in the center lifted up higher than expected

I see that with the newest version of svg2pdf.js(in online playground) the 2, 3 issues seem to be fixed. Will the percentage values be supported at any stage?

@HackbrettXXX
Copy link
Member

Percentage values would be implemented in the context of #154. We currently don't plan to implement it on our own but we will merge pull requests from the community.

I'm closing this since 2 & 3 are fixed and 1 will be tracked by #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants