-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source map points to nonexisting src/
folder in npm
package
#219
Comments
Thanks for the report and proposed fix! Honestly, I am not so much in favor of increasing the npm bundle size, just to make debugging a tiny bit easier. If you really need to debug and don't develop the npm module, I think it should be OK to require downloading specific files from GitHub just for this purpose and not have everyone and every build job download a bundle that contains >60% just "dead code bytes". How do other libraries handle this? What do you think? |
Describe the bug
Source map URLs are provided as comments in the
dist
bundles, but thesrc
directory does not exist in thenpm
package, giving many warnings of type:To Reproduce
Steps to reproduce the behavior:
npm install svg2pdf.js jspdf
import 'svg2pdf.js'
Expected behavior
Include
src/
innpm
package for the source map to work, or remove source map URL comments?Additional context
As a workaround, we currently run this post install command to remove warnings from
svg2pdf.js
source maps, but still have source maps for other packages:The text was updated successfully, but these errors were encountered: