add support for marker "orient" attribute and the "context-fill" and "context-stroke" values #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HackbrettXXX
requested changes
Sep 24, 2024
Added tests for marker, use and symbol
…nto fix-markers
|
@HackbrettXXX added some tests and also fixed a bug I found. It was a bit of a pain to debug this. Maybe we can move this repo to vite, esm and vitest to improve that situation. |
HackbrettXXX
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Alright, thanks for adding the tests, looks good now. I'll merge it. I will publish a release when some of the other PRs are merged, too.
Regarding vite and vitest: I agree, this would be good. However, the vitest browser mode is still experimental and svg2pdf needs a browser context. No idea how good it is already.
HackbrettXXX
changed the title
HackbrettXXX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went down the rabbit hole of context-fill and context-stroke and implemented marker orientation so that I can use this lib for my arrow-heads as well :D.
Specs for the context-props is https://svgwg.org/svg2-draft/painting.html#context-paint
This should fix #291 and enable context-paint for markers (and for use as well but I didnt test that one)