Fix prop-types to correcly assign props to components (fixes #991)

jsx-eslint · Jan 8, 2017 · bad47d6 · bad47d6
1 parent 13806f1
commit bad47d6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -586,7 +586,7 @@ module.exports = {
  }
 
  var component = components.get(utils.getParentComponent());
- var usedPropTypes = component && component.usedPropTypes || [];
+ var usedPropTypes = (component && component.usedPropTypes || []).slice();
 
  switch (type) {
  case 'direct':

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1415,6 +1415,19 @@ ruleTester.run('prop-types', rule, {
  jsx: true
  }
  }
+ }, {
+ code: [
+ 'export class Example extends Component {',
+ ' static propTypes = {',
+ ' onDelete: React.PropTypes.func.isRequired',
+ ' }',
+ ' handleDeleteConfirm = () => {',
+ ' this.props.onDelete();',
+ ' };',
+ ' handleSubmit = async ({certificate, key}) => {};',
+ '}'
+ ].join('\n'),
+ parser: 'babel-eslint'
  }
  ],