Different selection colors in fvim

[Kethku]

In nvim qt and terminal nvim, selection colors are set by the color scheme.

In fvim however they appear to be default or something similar

[yatli]

Noted.

Looks like a reverse color calculation error.

[Kethku]

Actually I think neovim doesn't use reverse colors to highlight. As you can see the background for the highlight changes based on the thing highlighted. Maybe I'm misunderstanding your comment, but I believe highlighting in vim is more complicated than a reverse color calculation.

[yatli]

@Kethku looking at your screenshot I believe what nvim-qt does is to simply swap fg and bg.

Note that in your screenshot the foreground color stays the same (which appears to be the default bg).

This is different from what I understand from the highlight color docs, but if this is the de facto behavior we can implement that.

edit: for clarity, it depends on the color scheme whether highlight is done by color reversing, or a new highlight group. gruvbox uses reverse colors.

[yatli]

the reverse color calculation is really off.. see 48b42e8

[yatli]

hmm, looks like nvim-gtk also implement the swapping scheme.
edit:

reverse:		reverse video. Foreground and background colors are
			switched.

looks like I have misunderstood the docs. The other frontends are implementing it correctly!

[yatli]

pushed out a new release (0.2-132)

[Kethku]

I don't think this is the correct fix. It appears that gruvbox itself is manually setting the selection colors. See this issue: morhetz/gruvbox#167

[Kethku]

Also note: in a compatible terminal, the colors do the same thing which says to me either the docs or wrong since they don't match the reference implementation or maybe the docs are just confusing

[Kethku]

I will try to spend some time to find more information. Thank you for your effort

[yatli]

with let g:gruvbox_invert_selection=0 before setting the colorscheme:

check your settings :)

[Kethku]

Fair, but given the change between fvim and terminal nvim/nvimqt, doesn't this constitute a bug?

[yatli]

the behavior should be identical to other frontends, could you please confirm?

[Kethku]

Yes I will. Thanks Thanks, Keith

…

________________________________ From: Yatao Li <[email protected]> Sent: Saturday, October 5, 2019 9:24:53 AM To: yatli/fvim <[email protected]> Cc: Keith Simmons <[email protected]>; Mention <[email protected]> Subject: Re: [yatli/fvim] Different selection colors in fvim (#82) the behavior should be identical to other frontends, could you please confirm? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#82?email_source=notifications&email_token=AAZLN3YZLV5AXVYHLM35H3TQNC5VLA5CNFSM4I4ESAS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANV7AA#issuecomment-538664832>, or mute the thread<https:/notifications/unsubscribe-auth/AAZLN36NYN4K6DOQUQLHE33QNC5VLANCNFSM4I4ESASQ>.

[Kethku]

Looks like I missed your #82 (comment) comment! This is working perfectly now. Thank you so much!