Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bad Windows shell integration #231

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

WillEhrendreich
Copy link
Contributor

the setup process doesn't integrate with the shell properly.

trying to open with the context menu gives this error dialog
image

i found the problem, after a bit.

the registry value it gives ends up having a slash before the filepath to fvim
so it would be something like
"\C:\Fvim\Fvim.exe" "%1"
instead of
"C:\Fvim\Fvim.exe" "%1"

changing to the second version in my registry editor does actually fix the problem.

the setup process doesn't integrate with the shell properly. 

trying to open with the context menu gives this error dialog
![image](https://user-images.githubusercontent.com/55286472/174404139-952199e2-c66c-4e73-91b6-af684a3a1698.png)

i found the problem, after a bit. 

the registry value it gives ends up having a slash before the filepath to fvim 
so it would be something like 
"\C:\Fvim\Fvim.exe" "%1" 
instead of 
"C:\Fvim\Fvim.exe" "%1"

changing to the second version in my registry editor does actually fix the problem.
@yatli
Copy link
Owner

yatli commented Apr 3, 2023

Oww how did I miss this PR.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants