This repository has been archived by the owner on May 1, 2023. It is now read-only.
note initial deposit requires 2 transactions #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofflangenderfer
requested review from
lehnberg and
milkyklim
as code owners
lehnberg
reviewed
Jan 25, 2021
lehnberg
suggested changes
Jan 25, 2021
There was a problem hiding this comment.
Thanks for the PR @geofflangenderfer! Looks good in general, see my comment about the fee warning, once this is fixed we can merge 👍
lehnberg
approved these changes
Jan 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a noob and it was unclear to me it takes 2 transactions to deposit into a vault the first time. This does a better job making that clear.