Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

updating linter to fix instead of check #198

Merged
merged 1 commit into from
Jan 25, 2021
Merged

updating linter to fix instead of check #198

merged 1 commit into from
Jan 25, 2021

Conversation

miguel567
Copy link
Contributor

I'm trying to fix our linter issue. I'm not an expert, but if we run on pull request a linter:fix instead of linter:check this would fix all the '*' and '-' issues potentially.

A normal User flow would be:

  1. Fork yearn-docs repo or pull form yearn-docs/master to my-repo/master to get the latest updates.
  2. Create a gitbook and fetch from my-repo/master
  3. Edit on gitbook interface anything that I need.
  4. Merge my gitbook changes through gitbook UI to my REPO.
  5. Check on my gitbook if everything looks fine.
  6. Go to my-repo and create a PR, submit PR.
  7. On PR the year-docs/ repo executes "npm run lint:fix" which changes all the '*' and '-'.
  8. Linter step passes.
  9. yearn-docs/ repo owner merges to master successfully.
  10. Yearn Gitbook Owner validates on LIVE that changes are correct.

Copy link
Contributor

@lehnberg lehnberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @miguel567 -- Let's see if this works, easy to revert otherwise 👍

@lehnberg lehnberg merged commit 174ebab into yearn:master Jan 25, 2021
milkyklim pushed a commit that referenced this pull request Jan 26, 2021
sambacha pushed a commit to sambacha/docs that referenced this pull request Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants