move curl body to file #622
Draft
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce curl argument size to avoid ENAMETOOLONG - use pwsh instead of powershell
aarnphm
requested changes
Sep 24, 2024
| @@ -122,7 +122,7 @@ M.stream = function(opts) | |||
| headers = spec.headers, | |||
| proxy = spec.proxy, | |||
| insecure = spec.insecure, | |||
| body = vim.json.encode(spec.body), | |||
There was a problem hiding this comment.
this is considered breaking, if the spec doesn't contains a binary body (iiuc that is what body_file is) then this will break for other provider.
| return string.format("%x", v) | ||
| end) | ||
|
|
||
| local body_file_path = string.format("%s\\AppData\\Local\\Temp\\avante_body_%s.json", os.getenv("USERPROFILE"), id) |
There was a problem hiding this comment.
let's not do this, this won't work on linux.
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows I noticed I kept getting
ENAMETOOLONGsince the curl argument was so long, so I moved the body into a file.This is a draft since I would def need to do this for the other providers too and the temp path is currently only valid for windows, but I am unsure if this is even the correct direction to go in.
Also I had to use
pwshinstead ofpowershellotherwise the build failed with: