Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release preparations #207

Merged
merged 22 commits into from
Mar 20, 2024
Merged

Release preparations #207

merged 22 commits into from
Mar 20, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Mar 18, 2024

PR Summary

  • Extension Addition
    This PR includes the addition of the 'uopz' extension in several workflow files as well as the composer.json file. Adding this extension improves the overall functionality of the workflows and development process.

  • PHPUnit Schema Update
    The PHPUnit XSD schema location was updated in the phpunit.xml.dist file. This move aligns with the most up-to-date PHPUnit schema, which can result in less confusion and more accurate testing.

  • Directory Checking & Error Messaging Update
    Improvements were made in src/Command/Schema/SchemaPhpCommand.php file to verify the existence of the destination directory before writing to it. This can prevent failures and errors before they occur. The error message for a write file failure was also made more detailed.

  • Test Case Additions & Message Modifications
    In the tests/Command/Migration/GenerateCommandTest.php file, a new test case was added for executing without confirmation. This helps to increase the scope of the testing process making it more reliable. Also, the expected success message for an empty migration name was updated.

  • Test File Update
    In the tests/Command/Schema/SchemaPhpCommandTest.php file, error handling and test coverage were improved by adding new checks and tests. This helps to make the testing more robust and detect potential bugs earlier.

  • Bootstrap File Addition
    Finally, a bootstrap.php file was added to the tests directory. Adding this file prevents bootstrapping code duplication across test files and ensures each test starts with the same initial state, aiding testing reliability and maintainability.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4290099) to head (e75a932).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #207   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       155       155           
===========================================
  Files             28        28           
  Lines            462       462           
===========================================
  Hits             462       462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev added the type:task Task label Mar 18, 2024
@arogachev arogachev added this to the 1.0 milestone Mar 18, 2024
@arogachev arogachev self-assigned this Mar 18, 2024
@arogachev arogachev linked an issue Mar 18, 2024 that may be closed by this pull request
@arogachev arogachev linked an issue Mar 18, 2024 that may be closed by this pull request
@arogachev arogachev requested a review from a team March 18, 2024 13:07
@arogachev arogachev linked an issue Mar 18, 2024 that may be closed by this pull request
@arogachev arogachev changed the base branch from master to coverage March 18, 2024 13:13
@arogachev arogachev marked this pull request as ready for review March 18, 2024 13:13
phpunit.xml.dist Outdated Show resolved Hide resolved
Base automatically changed from coverage to master March 19, 2024 07:29
# Conflicts:
#	src/Command/Schema/SchemaPhpCommand.php
#	tests/Command/Schema/SchemaPhpCommandTest.php
phpunit.xml.dist Outdated Show resolved Hide resolved
@arogachev arogachev merged commit 47a1456 into master Mar 20, 2024
14 checks passed
@arogachev arogachev deleted the release-preparations branch March 20, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants