Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ollama provider #866

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

venjiang
Copy link
Contributor

@venjiang venjiang commented Jul 26, 2024

Description

ollama llm provider is supports.

Known Issues:

  • ollama does not support function calling on stream mode, so non-stream mode calls are used when a function call occurs, it is a temporary solution.
  • ollama #6452 merge or ollama fully supports function calling on stream mode, this will be overwritten.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 10:43am

@venjiang venjiang self-assigned this Jul 26, 2024
@venjiang venjiang added the refactor Refactoring tasks label Jul 26, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 30.90909% with 38 lines in your changes missing coverage. Please review.

Project coverage is 79.08%. Comparing base (c91a388) to head (8000a4f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/bridge/ai/service.go 30.90% 36 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   79.86%   79.08%   -0.79%     
==========================================
  Files          50       50              
  Lines        2880     2935      +55     
==========================================
+ Hits         2300     2321      +21     
- Misses        412      442      +30     
- Partials      168      172       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@venjiang venjiang force-pushed the refactor/llm-ollama-provider branch from abf356f to 3cf6414 Compare August 21, 2024 11:16
@fanweixiao fanweixiao added the llm-providers LLM Bridge - LLM Providers label Sep 5, 2024
@venjiang venjiang marked this pull request as ready for review September 6, 2024 10:43
@fanweixiao fanweixiao merged commit 02356ec into master Sep 6, 2024
5 of 7 checks passed
@fanweixiao fanweixiao deleted the refactor/llm-ollama-provider branch September 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llm-providers LLM Bridge - LLM Providers refactor Refactoring tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants