Added support for multiple authentication types per operation. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
Feb 29, 2020
|
Thanks @malteburkert. Could you also please add a changelog entry |
…tional [] Modified Specs in order to comply with new generated artifacts and extended CHANGELOG.md
yonaskolb
reviewed
Mar 2, 2020
| @@ -4,6 +4,8 @@ | |||
| ### Fixed | |||
| - Fixed `'??' has non-optional type` warning #207 | |||
| - Fixed incorrect replacements in server variables #209 | |||
| - Fixed missing support for multiple authentication types per operation #214 #222 @malteburkert | |||
| - Fixed nullable references not being generated as optionals #216 @alephao | |||
There was a problem hiding this comment.
You’ll need to rebase or merge master in. PR #216 is in 4.3.1 that has since been released
|
Hi there, thank you @malteburkert for creating this MR. Since I need this feature as well I'd like to ask if I can help to get this PR merged? |
|
@yonaskolb could you please merge this PR? thanks in advance |
yonaskolb
approved these changes
Aug 5, 2020
| @@ -11,6 +11,7 @@ | |||
| ### Fixed | |||
| - Fixed `'??' has non-optional type` warning #207 | |||
| - Fixed incorrect replacements in server variables #209 | |||
| - Fixed missing support for multiple authentication types per operation #214 #222 @malteburkert | |||
There was a problem hiding this comment.
This needs to move up into the next version, but I'll do it on master after merging 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves issue #214