[297]Remove implicit mapping when an explicit is present in the spec #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanC
force-pushed
the
297-remove-mapping
branch
from
ed8b626
to
81a6d71
Compare
|
hey @yonaskolb do you think this will be merged? |
yonaskolb
reviewed
Mar 31, 2022
JanC
force-pushed
the
297-remove-mapping
branch
from
81a6d71
to
2f4a416
Compare
|
done 🎉 |
yonaskolb
reviewed
Mar 31, 2022
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| ### Fixed | |||
| - Fixed compilation with Xcode 13 #282 @sroebert | |||
| - Fixed duplicated switch cases when using explicit mappings in oneOf discriminator #297 @JanC | |||
There was a problem hiding this comment.
Oh, wrong version. I'll move up in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #297, this PR removes the implicit case when an explicit mapping is present in a
discriminatorfixes #297