Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bound on a different corpus #1

Open
Ricocotam opened this issue Jun 15, 2016 · 0 comments
Open

Out of bound on a different corpus #1

Ricocotam opened this issue Jun 15, 2016 · 0 comments

Comments

@Ricocotam
Copy link

Hey, I've been trying to use your code (which is amazingly clear and easy to understand, great job and thanks a lot) on a different corpus (this one) but I got an issue on line 102 of word2vec.lua

I don't know why but word_index had a value over vocab_size (in this case vocab_size is 1169). So I fixed it my changing line 104 :

  • from "if word_index > self.vocab_size then"
  • to "if word_index >= self.vocab_size then"

No PR, extremely simple fixing, but I can't figure out if it changes anything.

Thanks again for your code !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant