Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorization of output #16

Closed
schvabodka-man opened this issue Oct 4, 2017 · 9 comments · Fixed by #18
Closed

Colorization of output #16

schvabodka-man opened this issue Oct 4, 2017 · 9 comments · Fixed by #18

Comments

@schvabodka-man
Copy link

Are there any possibilities to add colorization to this tool? Everything is brilliant but absent of colorized stdout is real issue when copying/moving multiple files in bulk.

@dmerejkowsky
Copy link
Collaborator

dmerejkowsky commented Oct 4, 2017

Everything is brilliant

Thanks !

Are there any possibilities to add colorization to this tool?

Well, this may be a good opportunity to use python-cli-ui.

Somehow I feel I can trust its author

@dmerejkowsky
Copy link
Collaborator

Ask and you shall receive.

The pull request is a bit hard to review, sorry (lots of refactorings), but if you wanna give it a try, you're welcome.

If you want to skip the review, feel free to do so :). I'll merge it and publish a new release "soonish"

Cheers :)

@schvabodka-man
Copy link
Author

I know shit about Python so i can't "review" it properly, sorry.

@dmerejkowsky
Copy link
Collaborator

no problem :)

@dmerejkowsky
Copy link
Collaborator

You can still give your opinion about what the colored output look like:

pycp-global-colors

@schvabodka-man
Copy link
Author

Brown on dark background doesn't look very "eye friendly", but at all looks sweet

@dmerejkowsky
Copy link
Collaborator

Here you go:

pycp-yellow

@schvabodka-man
Copy link
Author

That's a lot nicer

@dmerejkowsky
Copy link
Collaborator

Ok, the v.8 is out. But there are serious performance problems (sorry)

See #20 for the details.

May be best to wait for 8.1 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants