Update AudioCapture.swift #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to init() to eliminate constant audio resets. .defaultToSpeaker and .mergeWithOthers added to improve compatibility with other plugins.
|
Hi @DaveHineman !! Thank you for submitting PR!! btw, why did you close it? It seems good modification!! |
|
It’s my first pull request, so I wasn’t sure if I was the one to close it. I can do it. When will you be able to put out a new version?On Dec 16, 2022, at 8:55 PM, ymd ***@***.***> wrote:
Hi @DaveHineman !! Thank you for submitting PR!! btw, why did you close it? It seems good modification!!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ysak-y
approved these changes
Dec 17, 2022
|
@DaveHineman Okay, I restored and approved this PR. Please click "Merge pull request" button. |
|
Sorry, there was only a ‘close pull request’ button. I clicked what looked like a ‘reload’ button by your name and then it said ‘resubmitting pull request.’
Looks like an accidentally closed this when I cleaned up my first pull attempts. I’ll start over.
… On Dec 17, 2022, at 12:04 AM, ymd ***@***.***> wrote:
@DaveHineman <https:/DaveHineman> Okay, I restored and approved this PR. Please click "Merge pull request" button.
—
Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https:/notifications/unsubscribe-auth/ALXQ4DBIESLCTNGP63T3EQTWNVJX3ANCNFSM6AAAAAAS75UCDM>.
You are receiving this because you were mentioned.
|
|
I really don't care about the credentials, feel free to just add the changes yourself and roll the version. Later I will learn how to do a pull request properly. |
ysak-y
approved these changes
Dec 18, 2022
This was referenced Dec 18, 2022
Merged
srmncnk
pushed a commit
to srmncnk/flutter_audio_capture
that referenced
this pull request
Dec 20, 2022
Update AudioCapture.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to init() to eliminate constant audio resets. .defaultToSpeaker and .mergeWithOthers added to improve compatibility with other plugins. I also added some code from the flutter audio_streams package that keeps the stream from dying when changing pages in an app (from https://pub.dev/packages/audio_streams).