Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: drop unmaintained install script #4634

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

neutrinoceros
Copy link
Member

Since it doesn't seem controversial, close #4633

I note that there are still a couple files referencing this script (in docker/**/Dockerfile). I assume these should be dropped too, but I'd like @Xarthisius' first hand opinion on it first.

@neutrinoceros neutrinoceros added dead code removing internal bits that have no effect build related to the build process labels Aug 15, 2023
@Xarthisius
Copy link
Member

Xarthisius commented Aug 15, 2023

Yeah, those Dockerfiles reference install_script from bitbucket... Feel free to drop entire docker/

Xarthisius
Xarthisius previously approved these changes Aug 15, 2023
@jzuhone
Copy link
Contributor

jzuhone commented Aug 15, 2023

image

jzuhone
jzuhone previously approved these changes Aug 15, 2023
@neutrinoceros neutrinoceros dismissed stale reviews from jzuhone and Xarthisius via 7243bb6 August 16, 2023 07:54
@neutrinoceros neutrinoceros merged commit 781d433 into yt-project:main Aug 17, 2023
15 checks passed
@neutrinoceros neutrinoceros deleted the drop_install_script branch August 17, 2023 14:42
@neutrinoceros neutrinoceros added this to the 4.3.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build process dead code removing internal bits that have no effect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: let's drop install_script.sh ?
3 participants