PERF: Optimize GAMER IO #4651
Open
PERF: Optimize GAMER IO #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
commented
Aug 25, 2023
|
LGTM |
jzuhone
previously approved these changes
Aug 25, 2023
|
Looking at the early results from Fido I'm wondering if perhaps the caching is breaking things. |
| @@ -91,13 +92,39 @@ def _read_particle_fields(self, chunks, ptf, selector): | |||
| data = self._group_particle[field][start:end] | |||
| yield (ptype, field), data[mask] | |||
|
|
|||
| @lru_cache(maxsize=8) # noqa | |||
There was a problem hiding this comment.
why the noqa comment ? (making it specific to the warning(s) you want to filter, e.g. noqa: E555, would answer my question)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some changes to optimize GAMER IO. I will be updating it in individual increments with new attempts at optimization, as while my tests here suggest it is indeed still producing correct results, I would like to see both the speed changes and the answers from Fido.