Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Experimentally turn off precounting AMR datasets #4678

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

matthewturk
Copy link
Member

Tests done by me, @cindytsai and @chrishavlin suggest that parallelism in particular is greatly limited by the amount of duplicated indexing that goes on across MPI tasks.

This is an experiment to see how we fare with turning off pre-counting, which should greatly reduce the amount of time spent in the counting routines, and potentially speed things up overall.

@matthewturk
Copy link
Member Author

Interestingly, the way the grid selections are set up doesn't lend itself to the resizing I'm attempting. I do think this is still quite a nice area for improvement, though, so I will try to lift the references up a level to perform this surgery more carefully.

@matthewturk
Copy link
Member Author

Resize behaves a bit strangely if the original shape is empty and you resize it to a single value. So this shows up when we have chunks consisting of a single grid with a single value selected, which happens inside streamlines.py. I've fixed this in this particular location, but there are remaining issues with nodal data for enzo.

@matthewturk
Copy link
Member Author

@yt-fido test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant