Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: fix manifest validation #5017

Merged
merged 1 commit into from
Oct 4, 2024
Merged

MNT: fix manifest validation #5017

merged 1 commit into from
Oct 4, 2024

Conversation

neutrinoceros
Copy link
Member

PR Summary

Hotfix for the (hopefully) last unforseen consequence from #5009

@neutrinoceros neutrinoceros added the blocker Highest priority level label Oct 4, 2024
@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Oct 4, 2024
@neutrinoceros neutrinoceros added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Oct 4, 2024
@chrishavlin
Copy link
Contributor

confused by the windows wheel failure here:

2024-10-04T12:33:57.0892873Z visualization/volume_rendering/tests/test_camera_attributes.py::test_scene_and_camera_attributes �[32mPASSED�[0m
2024-10-04T12:33:59.0693528Z visualization/volume_rendering/tests/test_composite.py::CompositeVRTest::test_composite_vr �[32mPASSED�[0m
2024-10-04T12:33:59.5242692Z visualization/volume_rendering/tests/test_lenses.py::LensTest::test_fisheye_lens �[32mPASSED�[0m
2024-10-04T12:33:59.7899717Z Windows fatal exception: access violation
2024-10-04T12:33:59.7900354Z 
2024-10-04T12:33:59.7900618Z Thread 0x00001b38 (most recent call first):
2024-10-04T12:33:59.7904308Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\threading.py", line 316 in wait
2024-10-04T12:33:59.7907306Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\threading.py", line 581 in wait
2024-10-04T12:33:59.7910225Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\tqdm\_monitor.py", line 60 in run
2024-10-04T12:33:59.7912509Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\threading.py", line 980 in _bootstrap_inner
2024-10-04T12:33:59.7914157Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\threading.py", line 937 in _bootstrap
2024-10-04T12:33:59.7914904Z 
2024-10-04T12:33:59.7915073Z Current thread 0x00000704 (most recent call first):
2024-10-04T12:33:59.7916395Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\render_source.py", line 596 in render
2024-10-04T12:33:59.7918243Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\render_source.py", line 135 in wrapper
2024-10-04T12:33:59.7920437Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\scene.py", line 621 in composite
2024-10-04T12:33:59.7923486Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\scene.py", line 224 in render
2024-10-04T12:33:59.7926574Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\scene.py", line 245 in _render_on_demand
2024-10-04T12:33:59.7929678Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\scene.py", line 251 in _setup_save
2024-10-04T12:33:59.7932703Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\scene.py", line 334 in save
2024-10-04T12:33:59.7935982Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\yt\visualization\volume_rendering\tests\test_lenses.py", line 49 in test_perspective_lens
2024-10-04T12:33:59.7939043Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\unittest\case.py", line 550 in _callTestMethod
2024-10-04T12:33:59.7941607Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\unittest\case.py", line 592 in run
2024-10-04T12:33:59.7944599Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\unittest\case.py", line 651 in __call__
2024-10-04T12:33:59.7947183Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\unittest.py", line 351 in runtest
2024-10-04T12:33:59.7949880Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 174 in pytest_runtest_call
2024-10-04T12:33:59.7952529Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_callers.py", line 103 in _multicall
2024-10-04T12:33:59.7955046Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
2024-10-04T12:33:59.7957815Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_hooks.py", line 513 in __call__
2024-10-04T12:33:59.7960004Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 242 in <lambda>
2024-10-04T12:33:59.7961508Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 341 in from_call
2024-10-04T12:33:59.7963016Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 241 in call_and_report
2024-10-04T12:33:59.7964525Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 132 in runtestprotocol
2024-10-04T12:33:59.7966061Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\runner.py", line 113 in pytest_runtest_protocol
2024-10-04T12:33:59.7967597Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_callers.py", line 103 in _multicall
2024-10-04T12:33:59.7969052Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
2024-10-04T12:33:59.7970480Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_hooks.py", line 513 in __call__
2024-10-04T12:33:59.7971946Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\main.py", line 362 in pytest_runtestloop
2024-10-04T12:33:59.7973414Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_callers.py", line 103 in _multicall
2024-10-04T12:33:59.7974861Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
2024-10-04T12:33:59.7976856Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_hooks.py", line 513 in __call__
2024-10-04T12:33:59.7978269Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\main.py", line 337 in _main
2024-10-04T12:33:59.7979714Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\main.py", line 283 in wrap_session
2024-10-04T12:33:59.7981312Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\main.py", line 330 in pytest_cmdline_main
2024-10-04T12:33:59.7982859Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_callers.py", line 103 in _multicall
2024-10-04T12:33:59.7984555Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
2024-10-04T12:33:59.7986161Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\pluggy\_hooks.py", line 513 in __call__
2024-10-04T12:33:59.7987689Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\config\__init__.py", line 175 in main
2024-10-04T12:33:59.7989206Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\lib\site-packages\_pytest\config\__init__.py", line 201 in console_main
2024-10-04T12:33:59.7990653Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-rxaueiif\cp39-win_amd64\venv-test\Scripts\pytest.exe\__main__.py", line 7 in <module>
2024-10-04T12:33:59.7991994Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\runpy.py", line 87 in _run_code
2024-10-04T12:33:59.7993361Z   File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\lib\runpy.py", line 197 in _run_module_as_main
2024-10-04T12:34:04.3125097Z visualization/volume_rendering/tests/test_lenses.py::LensTest::test_perspective_lens ::endgroup::Testing wheel...
2024-10-04T12:34:04.3126891Z                                                             �[31m✕ �[0m483.16s
2024-10-04T12:34:04.3166387Z ##[error]Command pytest -c D:\a\yt\yt/pyproject.toml --rootdir . --color=yes --pyargs yt -ra failed with code 3221225477. 
2024-10-04T12:34:04.3167600Z 
2024-10-04T12:34:04.4357943Z ##[error]Process completed with exit code 1.

doesn't seem related?

@neutrinoceros
Copy link
Member Author

Agreed that it seems unrelated, but it's worrisome nonetheless. Let's rerun and hope it's just a fluke.

@neutrinoceros
Copy link
Member Author

fluke it is ?

@chrishavlin chrishavlin merged commit 7ebe857 into yt-project:main Oct 4, 2024
19 checks passed
@neutrinoceros neutrinoceros deleted the mnt/fix_check_manifest branch October 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees
No one assigned
Labels
blocker Highest priority level infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @chrishavlin