Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I request a re-publish of the latest version for pip, or just increase the version number and publish. #32686

Closed
AntiMoron opened this issue Jan 9, 2024 · 8 comments

Comments

@AntiMoron
Copy link

AntiMoron commented Jan 9, 2024

Verbose log

Provided in the follow section.

Description

I think the source code is not aligned between binaries from homebrew(MacOS) and pip3.
Test command is as following:

youtube-dl -v  --skip-download --write-auto-sub --sub-lang=en -o test "https://www.youtube.com/watch?v=wAzYnx1J7YE"

Check the behavior:
image
Check the versions and envs:
image
Check verbose logs:
image

Verbose logs

Docker pip installed version:

root@help-desk-dev:/usr/local/bin# youtube-dl -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Encodings: locale utf-8, fs utf-8, out utf-8, pref utf-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.11.2 (CPython) - Linux-5.15.0-1047-aws-x86_64-with-glibc2.36
[debug] exe versions: none
[debug] Proxy map: {}
Usage: youtube-dl [OPTIONS] URL [URL...]

youtube-dl: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.

MacOS homebrew version:

~ youtube-dl -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Git HEAD: 705d2564d
[debug] Python version 3.12.1 (CPython) - macOS-13.0-arm64-arm-64bit
[debug] exe versions: none
[debug] Proxy map: {'http': 'http://127.0.0.1:7890', 'https': 'http://127.0.0.1:7890', 'socks': 'http://127.0.0.1:7890'}
Usage: youtube-dl [OPTIONS] URL [URL...]

youtube-dl: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.

Also I've tried to run "pip installed" youtbe-dl in the same python version as that from homebrew (python 3.12) , it remains the same, so I'm quiet sure that the binary published to pip is somehow not correct.

@AntiMoron
Copy link
Author

AntiMoron commented Jan 9, 2024

Hi core members, please take some time reviewing this, this can be fixed within 5 minutes.

@dstftw @phihag @dirkf

@dirkf
Copy link
Contributor

dirkf commented Jan 9, 2024

Review #30839.

The version in pypi is the same as the official last release, ie 2021.12.17.

You can install the nightly release use pip or pip3. Suitable command lines are shown in the discussion of #31530, as linked from #32069.

Otherwise duplicate of #31585.

@AntiMoron
Copy link
Author

@dirkf First of all, thank you for being patiently maintaining such a great repo, most of the repos I proposed issues/merge requests they don't respond at all.
Cut off the digression, I'm pretty sure I've read those threads before I submited this issue. I want to ask if it is possible that two same version's binaries from different package manager have different behaviors, because as you can see from above, I'm using ver. 2021.12.17 too. I'm willing to use the pip installed one, but the errors blocked my purpose of downloading some subtitles.

@ReenigneArcher
Copy link
Contributor

As a workaround you can install latest git version using pip.

python -m pip install git+https:/ytdl-org/youtube-dl.git

OR if you don't have git

python -m pip install https:/ytdl-org/youtube-dl/archive/master.zip

You can also put that in a requirements.txt file if needed.

git+https:/ytdl-org/youtube-dl.git

But FYI, the version will be the "same" because it comes from here:

__version__ = '2021.12.17'

@dirkf
Copy link
Contributor

dirkf commented Jan 10, 2024

Or, as I suggested, install from the nightly repo, which will give you an accurate version display.

@AntiMoron
Copy link
Author

AntiMoron commented Jan 10, 2024

Get it, thanks folks. The workaround works.

If we can republish to have the latest accurate binary that'll solve issues like mine. For version is reflected by the code mentioned before, there're still possibilities that the code that turns error to warning were not merged before 2021.12.17 being published to pip.

@bashonly
Copy link
Contributor

Homebrew applies their own patch to youtube-dl resulting in the warning

@dirkf
Copy link
Contributor

dirkf commented Jan 11, 2024

Indeed, the issue from #31530 is only fixed in nightly versions, in the main repo or builds derived from it (such as the nightly versions), or where some other packager, such as Homebrew, has patched the 2021.12.17 version. Some older versions may not have the bug, but will fail in other ways, with YT or other sites.

@dirkf dirkf closed this as completed Jan 11, 2024
@dirkf dirkf added the duplicate label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants