Change the linting #348
Merged
Change the linting #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just switches from JSHint to ESLint. ESLint has many good linting rules as default, and it makes more consistency code. The summary of changes as follows. * Intended code under `lib/` and `tests/`. * Follow default rules of ESLint as much as possible. * Disable following rules to avoid making large code changes for now. * `camelcase` * `new-cap` * `no-loop-func` * `no-process-exit` * `no-underscore-dangle` * `no-use-before-define`
|
CLA is valid! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just switches from JSHint to ESLint. ESLint has many good linting
rules as default, and it makes more consistency code. The summary of
changes as follows.
lib/andtests/.camelcasenew-capno-loop-funcno-process-exitno-underscore-dangleno-use-before-define