-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can annotations be shown to PRs on each commit on code? #43
Comments
+1 on this, any way to solve this would be really appreciated! |
I think this is a limitation of the GitHub annotations feature/API. You should ask GitHub support: https://support.github.com/ |
Also related to #4 |
It seems that we can now create annotation from the logger: https:/actions/toolkit/tree/main/packages/core#annotations |
My scenario is that I have integrated a static code analysis tool that produces a json file in the format needed for this action to work.
Sample of my action:
The annotations are displayed perfectly on the action page such as:
But when clicking on the finding nothing gets displayed on the file anywhere I looked for (main PR page, commit page, files changed page). If a specific line has changed during the last commit it works, but on then next push if the line does not get changed the failure message is not shown again.
First push with changed line:
Second push with unchanged line (yet still finding in the job):
Is there an option to maintain all findings even if not lines are changed on next commits such as this one according to my
annotations.json
file? Or even better to maintain all annotations on files changed?Thank you!
The text was updated successfully, but these errors were encountered: