-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jdtls startup script by default? #44
Labels
Comments
I'll leave this open, as I don't know what's the best course of action for most users. |
yveszoundi
added
help wanted
Extra attention is needed
question
Further information is requested
labels
Mar 5, 2024
This wouldn't be such a good decision after practical experimentation. Python dependencySome people might not know that
eglot-java initialization changesNeed to add the
LSP server initialization optionsUsers would need to configure themselves basic options (disabling or not gradle, etc.): See eglot/discussions/1222.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Background
By default,
eglot-java
doesn't use the Eclipse JDT LS startup scripts (jdtls
binary).jdtls
startup scripts existed (See Put this bash script into the appropriate location eclipse-jdtls/eclipse.jdt.ls#1823)jdtls
startup scripts require aPython
installationPython
is typically pre-installed on Linux, as many programs use thatPython
is not pre-installedPython
is also not bundled anymore as of MacOS Monterey 12.3Problem
By default,
eglot-java
dynamically modifies theeglot-server-programs
variable for launching the Eclipse JDT LS server.Some users might not realize that, even though it's documented (Package headers and GitHub project README), and that will result into both frustration and time wasted.
Scenario 1 - eglot changes how LSP servers can be mapped to programming modes
eglot
won't be able to start the LSP server, with obscure error emacs-lisp messagesScenario 2 - users have already configured eglot-server-programs to their liking for jdtls
Request
Changes
There's an existing variable that controls how
eglot-java
dynamically modifies the value ofeglot-server-programs
.The change will change the default value of
eglot-java-eglot-server-programs-manual-updates
tot
. The project documentation will also need to be updated to reflect thatExpected Impacts
eglot-java
when they do not want an involved configurationjdtls
startup scripts and mostly valueeglot-java
for its ability to automatically install the Eclipse JDT LS server.Python
installed and they might not be aware that thejdtls
script needs it...Caveats
I don't feel that
eglot
java defaults are that good myself: see joaotavora/eglot#1008 (comment). Either way, it's probably better to have an explicit user opt-in (eglot-java
magic), instead of people continuously running into configuration issues...The text was updated successfully, but these errors were encountered: