Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve landscape mode #227

Closed
4 tasks done
xmha97 opened this issue Sep 25, 2022 · 2 comments
Closed
4 tasks done

Improve landscape mode #227

xmha97 opened this issue Sep 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@xmha97
Copy link
Contributor

xmha97 commented Sep 25, 2022 •
edited
Loading

Checklist

  • I am able to reproduce the bug with the latest version.
  • I've checked that there is no issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

  • Open the app in landscape mode

Expected behavior

Move bottom navigation bar to left on landscape mode (like the GitHub app)

Screenshot_2022-09-25-15-08-53-874_com.github.android.jpg

Actual behavior

Screenshots/Screen recordings

Screenrecorder-2022-09-25-15-06-12-779.mp4

Screenshot_2022-09-25-15-06-32-669_com zionhuang music

Screenshot_2022-09-25-15-06-37-422_com zionhuang music

Logs

No response

Music version

0.4.1-stable

Android version

Android 12

Additional information

No response
@xmha97 xmha97 added the bug Something isn't working label Sep 25, 2022
@z-huang
Copy link
Owner

z-huang commented Sep 25, 2022

Thanks for reminding. Landscape mode experience is really bad currently. I will fix it.

z-huang added a commit that referenced this issue Sep 30, 2022
@z-huang
Collapse toolbar on scroll (#227)
881b1f6
@xmha97
Copy link
Contributor Author

xmha97 commented Oct 7, 2022 •
edited
Loading

A idea for extended buttom player on landscape mode:
Screenshot_2022-10-08-03-14-59-480_code name monkey retromusic
https:/RetroMusicPlayer/RetroMusicPlayer

@z-huang z-huang added enhancement New feature or request and removed bug Something isn't working labels Oct 11, 2022
z-huang added a commit that referenced this issue Oct 13, 2022
@z-huang
Improve landscape mode (#227)
857e121
@z-huang z-huang closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xmha97 @z-huang