Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Delete" button for artists #245

Closed
3 tasks done
xmha97 opened this issue Sep 28, 2022 · 1 comment
Closed
3 tasks done

Add "Delete" button for artists #245

xmha97 opened this issue Sep 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@xmha97
Copy link
Contributor

xmha97 commented Sep 28, 2022

Checklist

  • I've checked that there is no other issue about this feature request.
  • This issue contains only one feature request.
  • The title of this issue accurately describes the feature request.

Feature description

Screenshot_2022-09-28-06-03-45-504_com zionhuang music

Why do you want this feature?

Delete all songs from a artist

Additional information

No response

@xmha97 xmha97 added the enhancement New feature or request label Sep 28, 2022
@z-huang
Copy link
Owner

z-huang commented Sep 28, 2022

I'm not doing this feature because it's complicated to delete an artist. An artist may be related to an album with multiple artists. If you delete the artist, should the album be deleted as well? This is not good. The same conflict occurs when deleting a song. Should the album of the song be deleted as well? Therefore, my decision is:

  1. Album songs cannot be deleted. You can only delete the album and delete all the album songs.
  2. Artists cannot be deleted. They will be automatically deleted if they have no song.

@z-huang z-huang closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants