Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode issue #69

Closed
dhishkyaon opened this issue Jun 1, 2022 · 8 comments
Closed

Dark Mode issue #69

dhishkyaon opened this issue Jun 1, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@dhishkyaon
Copy link

dhishkyaon commented Jun 1, 2022

When Dark Mode is enabled -

Screenshot_20220601-074451.pngScreenshot_20220601-074145.png

DEVICE - PIXEL 4a, ANDROID 12L

@z-huang z-huang added the bug Something isn't working label Jun 1, 2022
@z-huang
Copy link
Owner

z-huang commented Jun 1, 2022

Can changing the dark mode settings solve the text color?

@bacteriostat
Copy link

bacteriostat commented Jun 1, 2022

I am on Android 11 and Looks like the "Follow System" option is broken when the system theme is dark.

Steps to reproduce:

  1. Set system theme as dark.
  2. In the app, select "Follow System" option in theme.
  3. Close the app.
  4. Open the app.

Observation:
The dark theme is partially applied as shown in 2nd screenshot above.

To fix the theme:

  1. Set theme as "Light"
  2. Set theme as "Dark"

@dhishkyaon
Copy link
Author

@z-huang yes. Light theme works flawlessly

@z-huang
Copy link
Owner

z-huang commented Jun 1, 2022

I found that dark mode works different in different ROMs. In MIUI, it works. But in other ones such as OneUI and Pixel phones, it doesn't work. That's why I didn't detect the bug when testing. As @bacteriostat said, choose light or dark theme to fix it temporarily, and wait for future update to fix it.

@z-huang
Copy link
Owner

z-huang commented Jun 4, 2022

@dhishkyaon Can you try this version 4ce54ba on Pixel? I've tested OneUI on Android 10 and it works well.

@dhishkyaon
Copy link
Author

i don't know how to build from source. If you can provide me .apk file then i can test it out :-)

@airon90
Copy link
Contributor

airon90 commented Jun 4, 2022

@dhishkyaon Go in Actions, select the "[Fix] Dark theme" commit, in the lower section named Artifacts select "app". You can press here as I did this for you. You will download a zip file containing an apk file you have to install so that you can test this app up to that commit

@dhishkyaon
Copy link
Author

dhishkyaon commented Jun 4, 2022

its working
thanks @airon90

@z-huang z-huang closed this as completed Jun 4, 2022
thornySoap pushed a commit to thornySoap/InnerTune that referenced this issue Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants